Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more explicit dependencies for Rails helper #565

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Use more explicit dependencies for Rails helper #565

merged 1 commit into from
Apr 1, 2021

Conversation

dbussink
Copy link
Contributor

This doesn't require all of Rails, only ActionView & Railties. Reducing the dependencies here means that it enables folks to use only parts of Rails and to slim down their applications by removing unused components of Rails.

This doesn't require all of Rails, only ActionView & Railties. Reduce
the dependencies here means that it enables folks to use only parts of
Rails and to slim down their applications by removing unused components
of Rails.
@vercel
Copy link

vercel bot commented Mar 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/HfCmCV3PF9PAPY6r5Bq6VGL5VqSs
✅ Preview: https://octicons-git-fork-dbussink-dbussink-reduce-dependencies-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview March 24, 2021 16:36 Inactive
@dbussink
Copy link
Contributor Author

@joelhawksley Looks like CI didn't run for some required builds, do they need to be explicitly triggered?

@joelhawksley
Copy link
Contributor

@dbussink I'm not sure. @colebemis mind having a look here?

@dbussink
Copy link
Contributor Author

dbussink commented Apr 1, 2021

@dbussink I'm not sure. @colebemis mind having a look here?

@colebemis Any idea what is up here and if we can get this merged?

@ashygee ashygee mentioned this pull request Apr 1, 2021
14 tasks
@colebemis colebemis changed the base branch from master to release-13.0.0 April 1, 2021 21:08
@colebemis colebemis merged commit 75435f5 into primer:release-13.0.0 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants